Adds directional windshear across a MAUL#2146
Open
David Flack (daflack) wants to merge 7 commits into
Open
Conversation
Contributor
|
|
David Flack (daflack)
requested review from
James Frost (jfrost-mo) and
James Warner (jwarner8)
Contributor
Author
James Warner (jwarner8)
left a comment
James Warner (jwarner8)
left a comment
Contributor
There was a problem hiding this comment.
Looks good, and methods look scientifically grounded. I haven't run the diagnostic myself, as don't have any appropriate data to test with.
Most comments minor, mostly just increasing explainability of tests/some bits of the code, so its easier for those not familiar to be able to understand.
| ].data | ||
| ) | ||
| elif ( | ||
| len(number_of_MAULs.coord("realization").points) |
Contributor
There was a problem hiding this comment.
this general code block could do with some single line comments, as its quite hard to follow what's happening
| The relative humidity is linearly interpolated onto the same grid as the vertical | ||
| derivative of the equivalent potenital temperature. The masks for each criterion are multiplied | ||
| together and then image processing is used to identify the number of objects (values of | ||
| ones that are connected) the depth of each object is found the deepest MAUL is used. The |
Contributor
There was a problem hiding this comment.
Suggested change
| ones that are connected) the depth of each object is found the deepest MAUL is used. The | |
| ones that are connected) where(?) the depth of each object is found the deepest MAUL is used. The |
| def test_maul_properties_direction_shear_cubelist( | ||
| maul_mask, u_wind_maul, v_wind_maul, precalc_direction_shear | ||
| ): | ||
| """Ensure correct directional shear across maul in cubelist.""" |
Contributor
There was a problem hiding this comment.
could this test be explained a bit more in docstring/comments?
Co-authored-by: James Warner <62252918+jwarner8@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1962
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.